WaveMaker alternated with storm [SOLVED]

[Sueur Aurelien]

Hi
In my older arduino, i has modified wavemaker for an alternated and storm.

I tried to copy the code to put in place of mode 4 in Ferduino code and i have add the night mode.

i am newbie in devellopement arduino and I can not find "periodo"

but "periodo" is too long, how I can change it to 700, 800, 900, for an example

Code: Select all

 else if(modo_selecionado == 4)
   switch (cmode){ 
     case 0: times = millis();
    value = int(128 + 127 * sin(2 * PI / periodo * times));
    Pump1PWM = 0;     
    Pump2PWM = value;
   if(value == 255){cmode = 1;} // при достижении уровня 253 - перейти к case 1
     break;
     
      case 1:
    times = millis();
    value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = value;
     Pump2PWM = 0;
   if(value == 253){cmode = 2;} // при достижении значения уровня 253 - перейти к case 1   
    break;
 
    case 2: times = millis();
   value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = 255;
     Pump2PWM = 0;   
  if(value == 100){cmode = 3;}
    break;
 
    case 3: times = millis();
   value = int(128 + 127 * sin(2 * PI / periodo * times));
      Pump1PWM = 0;
      Pump2PWM = 255;
  if(value == 100){cmode = 4;}
    break;
 
    case 4: times = millis();
   value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = value;
     Pump2PWM = 0;
  if(value == 255){cmode = 5;}
    break;
 
    case 5: times = millis();
   value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = 0;
     Pump2PWM = value;
  if(value == 255){cmode = 6;}   
    break;
 
    case 6: times = millis();
   value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = 255;
     Pump2PWM = 255;
  if(value == 252){cmode = 7;}
    break;
   
    case 7: times = millis();
   value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = 0;  // 255
     Pump2PWM = 0;  // 255
  if(value == 20){cmode = 0;}
    break;
   }
 
  else if(modo_selecionado == 5)
{
 Pump1PWM = Pump1PWM_temp;
 Pump2PWM = Pump2PWM_temp;
}
  if(Pump1PWM > 255)
  {
    Pump1PWM = 255;
  }
  else if(Pump1PWM < 0)
  {
    Pump1PWM = 0;
  }
  else if(Pump2PWM > 255)
  {
    Pump2PWM = 255;
  }
  else if(Pump2PWM < 0)
  {
    Pump2PWM = 0;
  }
if((bled_out == 0) && (wled_out == 0) && (rbled_out  == 0) && (rled_out == 0))
  {
  analogWrite(wavemaker1, int(Pump1PWM * 0.50));
  analogWrite(wavemaker2, int(Pump2PWM * 0.50));
  }
  else
  {
  analogWrite(wavemaker1, Pump1PWM );
  analogWrite(wavemaker2, Pump2PWM );   
  }
}


Thank you in advanced

[Fernando Garcia]

Hi!

Here you can change the step and the interval:

https://github.com/FernandoGarcia/Fedui ... .ino#L1061

Code: Select all

          duracao -= 1000;
          if(duracao < 1000)
          {
            duracao = 5000;
          }


Example:

Code: Select all

          duracao -= 100;
          if(duracao < 100)
          {
            duracao = 5000;
          }


Best regards.

[Sueur Aurelien]

thank again

I have changed "duraco" par "periodo" in Procesmytouch.ino

Code: Select all

else if(modo_selecionado == 4)
      {
        if ((x>=peRB[0]) && (x<=peRB[2]) && (y>=peRB[1]) && (y<=peRB[3]))  // Duração do intervalo -
        {
          //waitForIt(peRB[0], peRB[1], peRB[2], peRB[3]);
          periodo -= 100;
          if(periodo < 100)
          {
            periodo = 5000;
          }
          waveScreen();
        }       
        else if ((x>=peRC[0]) && (x<=peRC[2]) && (y>=peRC[1]) && (y<=peRC[3]))  // intervalo +
        {
          //waitForIt(peRC[0], peRC[1], peRC[2], peRC[3]);
          periodo += 1000;
          if(periodo > 5000)
          {
            periodo = 1000;
          }
          waveScreen();
        }       

and changed in L_Menu Modo 4 =periodo

Code: Select all

 if((modo_selecionado == 1) || (modo_selecionado == 2)|| (modo_selecionado == 4))
  {
    myGLCD.print("     ", 75, 145);
    myGLCD.printNumI(periodo, 75, 145);
  }
  else if((modo_selecionado == 3)) 
  {
    myGLCD.print("    ", 85, 150);
    myGLCD.printNumI(duracao, 85, 150); 
  }


The difficult for me, it's for one fonction they are three ways: fonction, graphic and touch, that my loses some

[Fernando Garcia]

You need change here also:

Code: Select all

 
        periodo += 1000;
          if(periodo > 5000)
          {
            periodo = 1000;
          }


[Sueur Aurelien]

No When i changed also "duraco" by "periodo" touch is ok, but but the display does not follow.

when i changed L_menu, it's good

[Fernando Garcia]

I don't understand what you mean.

Some images can help.

[Sueur Aurelien]

nothing is good

I think it works

Thank you

[Sueur Aurelien]

There is a bug in the code that I added the switch case 0: to case1: to case 2: .... do not work, it's don't switch

Can you take a look that if you see a problem ? "value== 255"

Code: Select all

 else if(modo_selecionado == 4)
   switch (cmode){ 
     case 0: times = millis();
    value = int(128 + 127 * sin(2 * PI / periodo * times));
    Pump1PWM = 0;     
    Pump2PWM = value;
   if(value == 255){cmode = 1;} //
     break;
     
      case 1:
    times = millis();
    value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = value;
     Pump2PWM = 0;
   if(value == 253){cmode = 2;} // при достижении значения уровня 253 - перейти к case 1   
    break;
 
    case 2: times = millis();
   value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = 255;
     Pump2PWM = 0;   
  if(value == 100){cmode = 3;}
    break;
 

[Fernando Garcia]

This is a question of probability.

What's the probability of "value" be 255 to this equation?

Code: Select all

value = int(128 + 127 * sin(2 * PI / periodo * times));


[Sueur Aurelien]

Good question, i don't know, the original value=253, but i want Pump1PWM for 20 minutes after Pump2PWM for 20 minutes ...
On Jarduino was work but equation is different "value = 128+127*cos(2*PI/periode*(times-(starttime+startvalue))); "

[Fernando Garcia]

The probability is 1 / 127 or 0.7874 %.

[Sueur Aurelien]

yes it's very difficult but i have tested with value ==100, it's same problem

i tried with millis but it's difficult for me.

if((millis() - temps) > 1800000) ...

Code: Select all

 else if(modo_selecionado == 4)
   switch (cmode){ 
     case 0: times = millis();
    value = int(128 + 127 * sin(2 * PI / periodo * times));
    Pump1PWM = 0;     
    Pump2PWM = value;
   if((millis() - temps) > 1800000){cmode = 1;}
   temps = millis();
   break;
     
      case 1:
    times = millis();
    value = int(128 + 127 * sin(2 * PI / periodo * times));
     Pump1PWM = value;
     Pump2PWM = 0;
   if((millis() - temps) > 1800000){cmode = 2;}
    temps = millis();
    break;

[Sueur Aurelien]

Hi, if anyone can help me ?

thank you

[Fernando Garcia]

Hi!

Try this:

Code: Select all

   if((millis() - temps) > 1800000)
{
 cmode = 1;
  temps = millis();
}
   break;


You need wait 30 minutes to see the result or change the interval.

Best regards.

[Sueur Aurelien]

Hi Fernando

Thank you

I tried but don't switch to case 1:

Code: Select all

void Wavemaker()
{
  long temps = millis();
  int cmode = 0; 
  int value = 0;
  long times = millis();


 else if(modo_selecionado == 4)
   switch (cmode){ 
    case 0:
    value = int(128 + 127 * sin(2 * PI / periodo * times));
    Pump1PWM = 0;     
    Pump2PWM = value;
   if((millis() - temps) > 18000)
     {
     cmode = 1;
     temps = millis();
     }
     break;
     
    case 1:
    value = int(128 + 127 * sin(2 * PI / periodo * times));
    Pump1PWM = value;
    Pump2PWM = 0;
   if((millis() - temps) > 18000)
     {
     cmode = 0;
     temps = millis();
     }
     break;
   }


I tried several way and it never switches !!!!

[Fernando Garcia]

You can't put this variable as local.

Code: Select all

long temps = millis();

Should be global variable.

Put here:

https://github.com/FernandoGarcia/Fedui ... a.ino#L886

After:

Code: Select all

byte Pump2PWM = 0;

[Sueur Aurelien]

this variable also ?

Code: Select all

int cmode = 0;

[Fernando Garcia]

Sueur Aurelien » 1 minute ago wrote:

this variable too ?

Code: Select all

int cmode = 0;

Yes.

[Sueur Aurelien]

YEAHHHH!!!!!

A BIG THANK YOU

it's been several days that I break my head on it

[Fernando Garcia]

Cool!

Some suggestions of good practice of programming.

Code: Select all

int cmode = 0;
int value = 0;


"cmode" and "value" never will be higher than 255 so use it:

Code: Select all

byte cmode = 0;
byte value = 0;